feat: lazy loading history #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.props.currentChannel.get('loadingStatus') !== 'LOADING' | ||
| ) { | ||
| // Prevent scroll jump | ||
| this.state.skipNextScroll = true; |
There was a problem hiding this comment.
Use method setState for mutating state.
But It would be class variable in this case (this. skipNextScroll)
We load history in packs of 20 messages (sorry, this value if hardcoded for now due to lack of centrlized settings storage). Messages are counted in reverse order from baseDate.
This feature could get a little more polish like a loading indicator or more smooth scroll, but well, day has only 24 hours...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature simplifies the state of an app a lot: messages are removed from initial state and are lazily loaded my
Messagescomponent itself.History loads in packs of 20 messages, based on the
baseDate. Loading status for each channel is stored in the local channels state, next tolastSeen.Resolves: #278 #302